Thread (2 messages) 2 messages, 2 authors, 2026-01-26

Re: [PATCH] sunrpc: fix a resource leak in gss_proxy_save_rsc()

From: "Chuck Lever" <cel@kernel.org>
Date: 2026-01-26 16:43:49
Also in: linux-nfs, lkml, stable


On Sun, Jan 25, 2026, at 9:10 PM, Haoxiang Li wrote:
quoted hunk ↗ jump to hunk
In gss_proxy_save_rsc(), if gss_import_sec_context() fails,
call gss_mech_put() to release the reources acquired by
gss_mech_get_by_OID().

Fixes: 030d794bf498 ("SUNRPC: Use gssproxy upcall for server RPCGSS 
authentication.")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <redacted>
---
 net/sunrpc/auth_gss/svcauth_gss.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/sunrpc/auth_gss/svcauth_gss.c 
b/net/sunrpc/auth_gss/svcauth_gss.c
index a8ec30759a18..cdae1f23adfc 100644
--- a/net/sunrpc/auth_gss/svcauth_gss.c
+++ b/net/sunrpc/auth_gss/svcauth_gss.c
@@ -1268,8 +1268,10 @@ static int gss_proxy_save_rsc(struct 
cache_detail *cd,
 						ud->out_handle.len,
 						gm, &rsci.mechctx,
 						&expiry, GFP_KERNEL);
-		if (status)
+		if (status) {
+			gss_mech_put(gm);
 			goto out;
+		}
Is the reference already released via free_svc_cred() ? This
change might introduce a double-free bug.

 		getboottime64(&boot);
 		expiry -= boot.tv_sec;
-- 
2.25.1
-- 
Chuck Lever
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help