On Mon, Jan 26, 2026 at 12:23 AM Jakub Kicinski [off-list ref] wrote:

On Fri, 23 Jan 2026 02:51:07 +0800 David Yang wrote:

quoted

On 64bit arches, struct u64_stats_sync is empty and provides no help
against load/store tearing. Convert to u64_stats_t to ensure atomic
operations.

Eric, could you comment if this matters? I expect David may send a
non-trivial number of these, I want to make sure we're making good
use of everyone's time here. 64b accesses are not torn on 64b arches,
and never used for control flow.

I  added u64_stats_add()/u64_stats_inc() back in 2019, and never bothered
sending dozens of patches.

Presumably compilers could be really dumb back then, I am not sure
this is still the case today.