Re: [net-next PATCH v2 2/3] net: phy: as21xxx: add support for DBG command

From
Jakub Kicinski <kuba@kernel.org>
Date
2026-01-25 22:33:27
Also in
lkml
Reply to
Christian Marangi, 2026-01-23
On Fri, 23 Jan 2026 13:00:30 +0100 Christian Marangi wrote:
Rework the msg send logic to support sending DBG command.

These DBG command use a special way to send and receive data and use
data in u8 size and are used to tweak advanced (and later introduced)
feature of the PHY.
Unfortunately we can't have unused static functions, even transiently:

drivers/net/phy/as21xxx.c:631:12: warning: unused function 'aeon_ipc_poll' [-Wunused-function]
  631 | static int aeon_ipc_poll(struct phy_device *phydev)
      |            ^~~~~~~~~~~~~
drivers/net/phy/as21xxx.c:653:12: warning: unused function 'aeon_ipc_dbg_cmd' [-Wunused-function]
  653 | static int aeon_ipc_dbg_cmd(struct phy_device *phydev, u16 dbg_sec,
      |            ^~~~~~~~~~~~~~~~
drivers/net/phy/as21xxx.c:666:12: warning: unused function 'aeon_ipc_dbg_read_buf' [-Wunused-function]
  666 | static int aeon_ipc_dbg_read_buf(struct phy_device *phydev, u16 *buf)
      |            ^~~~~~~~~~~~~~~~~~~~~
drivers/net/phy/as21xxx.c:689:12: warning: unused function 'aeon_ipc_dbg_write_buf' [-Wunused-function]
  689 | static int aeon_ipc_dbg_write_buf(struct phy_device *phydev, u8 *data,
      |            ^~~~~~~~~~~~~~~~~~~~~~
-- 
pw-bot: cr
Thread (8 messages) 8 messages, 3 authors, last reply 2026-01-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help