Thread (3 messages) 3 messages, 3 authors, 2026-01-25

Re: [PATCH v3 net] net/mlx5: Fix return type mismatch in mlx5_esw_vport_vhca_id()

From: Tariq Toukan <hidden>
Date: 2026-01-25 06:46:19
Also in: linux-rdma, lkml


On 23/01/2026 10:57, Zeng Chi wrote:
quoted hunk ↗ jump to hunk
From: Zeng Chi <redacted>

The function mlx5_esw_vport_vhca_id() is declared to return bool,
but returns -EOPNOTSUPP (-45), which is an int error code. This
causes a signedness bug as reported by smatch.

This patch fixes this smatch report:
drivers/net/ethernet/mellanox/mlx5/core/eswitch.h:981 mlx5_esw_vport_vhca_id()
warn: signedness bug returning '(-45)'

Fixes: 1baf30426553 ("net/mlx5: E-Switch, Set/Query hca cap via vhca id")
Reviewed-by: Parav Pandit <redacted>
Signed-off-by: Zeng Chi <redacted>
---
v2 -> v3:
- Shortened the commit ID in the `Fixes:` tag to 12 characters as suggested.
- Added a `Reviewed-by:` tag from Parav Pandit [off-list ref].

v2:Added the required Fixes tag and specified target branch net in subject prefix
---
  drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
index ad1073f7b79f..e7fe43799b23 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
@@ -1009,7 +1009,7 @@ mlx5_esw_host_functions_enabled(const struct mlx5_core_dev *dev)
  static inline bool
  mlx5_esw_vport_vhca_id(struct mlx5_eswitch *esw, u16 vportn, u16 *vhca_id)
  {
-	return -EOPNOTSUPP;
+	return false;
  }
  
  #endif /* CONFIG_MLX5_ESWITCH */
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help