[PATCH net-next V5 00/15] devlink and mlx5: Support cross-function rate scheduling · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
[PATCH net-next V5 01/15] documentation: networking: add shared devlink documentation · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
[PATCH net-next V5 02/15] devlink: introduce shared devlink instance for PFs on same chip · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
[PATCH net-next V5 03/15] devlink: Reverse locking order for nested instances · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
[PATCH net-next V5 04/15] devlink: Add helpers to lock nested-in instances · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
[PATCH net-next V5 05/15] devlink: Refactor devlink_rate_nodes_check · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
[PATCH net-next V5 06/15] devlink: Decouple rate storage from associated devlink object · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
Re: [net-next,V5,06/15] devlink: Decouple rate storage from associated devlink object · Jakub Kicinski <kuba@kernel.org> · 2026-01-22
Re: [net-next,V5,06/15] devlink: Decouple rate storage from associated devlink object · Cosmin Ratiu <hidden> · 2026-01-22
[PATCH net-next V5 07/15] devlink: Add parent dev to devlink API · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
[PATCH net-next V5 08/15] devlink: Allow parent dev for rate-set and rate-new · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
[PATCH net-next V5 09/15] devlink: Allow rate node parents from other devlinks · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
[PATCH net-next V5 10/15] net/mlx5: Add a shared devlink instance for PFs on same chip · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
Re: [net-next,V5,10/15] net/mlx5: Add a shared devlink instance for PFs on same chip · Jakub Kicinski <kuba@kernel.org> · 2026-01-22
Re: [net-next,V5,10/15] net/mlx5: Add a shared devlink instance for PFs on same chip · Jakub Kicinski <kuba@kernel.org> · 2026-01-22
Re: [PATCH net-next V5 10/15] net/mlx5: Add a shared devlink instance for PFs on same chip · Krzysztof Kozlowski <krzk@kernel.org> · 2026-01-22
Re: [PATCH net-next V5 10/15] net/mlx5: Add a shared devlink instance for PFs on same chip · Cosmin Ratiu <hidden> · 2026-01-22
[PATCH net-next V5 11/15] net/mlx5: Expose a function to clear a vport's parent · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
Re: [net-next,V5,11/15] net/mlx5: Expose a function to clear a vport's parent · Jakub Kicinski <kuba@kernel.org> · 2026-01-22
Re: [net-next,V5,11/15] net/mlx5: Expose a function to clear a vport's parent · Jakub Kicinski <kuba@kernel.org> · 2026-01-22
[PATCH net-next V5 13/15] net/mlx5: qos: Support cross-device tx scheduling · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
[PATCH net-next V5 12/15] net/mlx5: Store QoS sched nodes in the sh_devlink · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
Re: [net-next,V5,12/15] net/mlx5: Store QoS sched nodes in the sh_devlink · Jakub Kicinski <kuba@kernel.org> · 2026-01-22
Re: [net-next,V5,12/15] net/mlx5: Store QoS sched nodes in the sh_devlink · Cosmin Ratiu <hidden> · 2026-01-22
[PATCH net-next V5 14/15] net/mlx5: qos: Enable cross-device scheduling · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20
[PATCH net-next V5 15/15] net/mlx5: Document devlink rates · Tariq Toukan <tariqt@nvidia.com> · 2026-01-20

Re: [PATCH net-next V5 10/15] net/mlx5: Add a shared devlink instance for PFs on same chip

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-01-22 07:42:35
Also in: linux-doc, linux-rdma, lkml

On 20/01/2026 08:57, Tariq Toukan wrote:

quoted hunk ↗ jump to hunk

+
+static const struct devlink_ops mlx5_shd_ops = {
+};
+
+int mlx5_shd_init(struct mlx5_core_dev *dev)
+{
+	u8 *vpd_data __free(kfree) = NULL;

So you just ignore people's comments. What is the point of review then?

Please respond to review and do not send the same buggy or wrong code.


Best regards,
Krzysztof

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help