On Sat, Jan 17, 2026 at 06:31:45PM -0800, Jakub Kicinski wrote:

On Sat, 17 Jan 2026 18:29:07 -0800 Jakub Kicinski wrote:

quoted

quoted

@@ -286,8 +287,33 @@ static int xway_gphy_config_init(struct phy_device *phydev)
 		return err;

 	/* Use default LED configuration if 'leds' node isn't defined */
-	if (!of_get_child_by_name(np, "leds"))
+	if (!of_get_child_by_name(np, "leds")) {
 		xway_gphy_init_leds(phydev);
+	} else {  

Does this leak the device_node reference returned by of_get_child_by_name()?

Of course this is a pre-existing issue but could you fix it first
in net then proceed with this submission? Otherwise we'll have a
conflict.

Ack. I'll send the fix for this to net first, then resend this patch
after the merge of net-next and net.