Re: [PATCH net-next 1/9] net: benet: convert to use .get_rx_ring_count
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-01-18 02:15:54
Also in:
linux-arm-kernel, linux-mediatek, lkml
On Thu, 15 Jan 2026 06:37:48 -0800 Breno Leitao wrote:
-static int be_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd,
- u32 *rule_locs)
-{
- struct be_adapter *adapter = netdev_priv(netdev);
-
- if (!be_multi_rxq(adapter)) {
- dev_info(&adapter->pdev->dev,
- "ethtool::get_rxnfc: RX flow hashing is disabled\n");
- return -EINVAL;
- }I think we need to add this check to set_rxfh now. The error coming from get_rxnfc/GRXRINGS effectively shielded the driver from set_rxfh calls ever happening when there's only 1 ring. Now they will happen. Applied the rest