Re: [PATCH v3 2/3] dt-bindings: net: nxp,s32-dwmac: Use the GPR syscon
From: Rob Herring <robh@kernel.org>
Date: 2026-01-16 17:57:14
Also in:
imx, linux-devicetree, lkml
On Tue, Jan 13, 2026 at 05:13:32PM +0300, Dan Carpenter wrote:
quoted hunk ↗ jump to hunk
The S32 chipsets have a GPR region which has a miscellaneous registers including the GMAC_0_CTRL_STS register. Originally, this code accessed that register in a sort of ad-hoc way, but it's cleaner to use a syscon interface to access these registers. We still need to maintain the old method of accessing the GMAC register but using a syscon will let us access other registers more cleanly. Signed-off-by: Dan Carpenter <redacted> --- v3: Better documentation about what GMAC_0_CTRL_STS register does. v2: Add the vendor prefix to the phandle Fix the documentation .../devicetree/bindings/net/nxp,s32-dwmac.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)diff --git a/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml b/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml index 2b8b74c5feec..cc0dd3941715 100644 --- a/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml@@ -32,6 +32,17 @@ properties: - description: Main GMAC registers - description: GMAC PHY mode control register + nxp,phy-sel: + $ref: /schemas/types.yaml#/definitions/phandle-array + items: + - description: phandle to the GPR syscon node + - description: offset of PHY selection register
It should be:
items:
- items:
- description: ...
- description: ...
Because it is 1 phandle+args entry of 2 cells.
Rob