Thread (3 messages) 3 messages, 3 authors, 2026-01-16

Re: [PATCH net] usbnet: fix crash due to missing BQL accounting after resume

From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-01-16 03:53:46
Also in: linux-usb, lkml

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski [off-list ref]:

On Tue, 13 Jan 2026 08:51:38 +0100 you wrote:
In commit 7ff14c52049e ("usbnet: Add support for Byte Queue Limits
(BQL)"), it was missed that usbnet_resume() may enqueue SKBs using
__skb_queue_tail() without reporting them to BQL. As a result, the next
call to netdev_completed_queue() triggers a BUG_ON() in dql_completed(),
since the SKBs queued during resume were never accounted for.

This patch fixes the issue by adding a corresponding netdev_sent_queue()
call in usbnet_resume() when SKBs are queued after suspend. Because
dev->txq.lock is held at this point, no concurrent calls to
netdev_sent_queue() from usbnet_start_xmit() can occur.

[...]
Here is the summary with links:
  - [net] usbnet: fix crash due to missing BQL accounting after resume
    https://git.kernel.org/netdev/net/c/c4efd7a770c5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help