Re: [PATCH net-next v8 7/9] eth: bnxt: support qcfg provided rx page size

From
Jakub Kicinski <kuba@kernel.org>
Date
2026-01-14 03:36:15
Also in
bpf, io-uring, linux-doc, linux-kselftest, linux-rdma, lkml
Reply to
Pavel Begunkov, 2026-01-09
On Fri,  9 Jan 2026 11:28:46 +0000 Pavel Begunkov wrote:
quoted hunk ↗ jump to hunk
@@ -4342,7 +4343,8 @@ static void bnxt_init_ring_struct(struct bnxt *bp)
 		if (!rxr)
 			goto skip_rx;
 
-		rxr->rx_page_size = BNXT_RX_PAGE_SIZE;
+		rxq = __netif_get_rx_queue(bp->dev, i);
+		rxr->rx_page_size = rxq->qcfg.rx_page_size;
Pretty sure I asked for the netdev_queue_config() helper to make 
a return, instead of drivers poking directly into core state.
Having the config live in rxq directly is also ugh.

But at this stage we're probably better off if you just respin
to fix the nits from Paolo and I try to de-lobotimize the driver
facing API. This is close enough.
Thread (19 messages) 19 messages, 3 authors, last reply 2026-01-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help