[PATCH v3 net 0/2] net: vlan: fix skb_panic bug in vlan_dev_hard_header()
From: Chen Zhen <hidden>
Date: 2026-01-12 07:49:39
Also in:
lkml
This series fix a skb_panic bug in vlan_dev_hard_header(). If a vlan device with reorder_hdr off is created without hw offload feature, but up with hw offload on, the ndisc skb has no enough room for vlan hdr in vlan_dev_hard_header() and finally panic. The first patch fixes the bug itself by also setting header_ops of vlan dev when offload feature is toggled. The second patch adds a regression test for this bug. --- v2 -> v3: - Add a comment to test script to silence shellcheck SC2329 warning - v2: https://lore.kernel.org/all/20260107033423.1885071-1-chenzhen126@huawei.com/ (local) v1 -> v2: - Address format issues of commit message - Add a selftest to catch re-occurrence of this issue as suggested by Jakub - v1: https://lore.kernel.org/all/20251231035419.23422-1-chenzhen126@huawei.com/ (local) Chen Zhen (2): net: vlan: set header_ops to match hard_header_len when hw offload is toggled selftests: vlan: add test for turn on hw offload with reorder_hdr off net/8021q/vlan.c | 5 +-- net/8021q/vlan.h | 3 ++ net/8021q/vlan_dev.c | 22 ++++++++----- tools/testing/selftests/net/Makefile | 1 + .../testing/selftests/net/vlan_hw_offload.sh | 31 +++++++++++++++++++ 5 files changed, 50 insertions(+), 12 deletions(-) create mode 100755 tools/testing/selftests/net/vlan_hw_offload.sh -- 2.33.0