Thread (24 messages) flat view 24 messages, 3 authors, 2026-01-12

Re: [PATCH 04/15] net: ftgmac100: Use devm_alloc_etherdev()

From: Simon Horman <horms@kernel.org>
Date: 2026-01-07 15:55:23
Also in: lkml

On Mon, Jan 05, 2026 at 03:08:50PM +0800, Jacky Chou wrote:
quoted hunk ↗ jump to hunk
From: Andrew Lunn <andrew@lunn.ch>

Make use of devm_alloc_etherdev() to simplify cleanup.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
 drivers/net/ethernet/faraday/ftgmac100.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
index f07167cabf39..75c7ab43e7e9 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.c
+++ b/drivers/net/ethernet/faraday/ftgmac100.c
@@ -1877,10 +1877,9 @@ static int ftgmac100_probe(struct platform_device *pdev)
 		return irq;
 
 	/* setup net_device */
-	netdev = alloc_etherdev(sizeof(*priv));
+	netdev = devm_alloc_etherdev(&pdev->dev, sizeof(*priv));
 	if (!netdev) {
-		err = -ENOMEM;
-		goto err_alloc_etherdev;
+		return -ENOMEM;
 	}
nit: There is no longer any need for {} here.

...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help