Re: [PATCH net-next 2/2] netconsole: convert to NBCON console infrastructure
From: Marcos Paulo de Souza <hidden>
Date: 2026-01-07 15:05:03
Also in:
lkml
From: Marcos Paulo de Souza <hidden>
Date: 2026-01-07 15:05:03
Also in:
lkml
On Tue, 2026-01-06 at 07:43 -0800, Breno Leitao wrote:
Hello Marcos, On Fri, Jan 02, 2026 at 12:54:14AM -0300, Marcos Paulo de Souza wrote:quoted
On Mon, 22 Dec 2025 06:52:11 -0800 Breno Leitao [off-list ref] wrote:quoted
+ if (!nbcon_enter_unsafe(wctxt)) + continue;In this case, I believe that it should return directly? If it can't enter in the unsafe region the output buffer is not reliable anymore, so retrying the send the buffer to a different target isn't correct anymore. Petr, John, do you agree?That makes sense. I undersatnd that the ownership will not be re-acquired here by just looping through the netconsole targets, right?
Yes, take a look into the drivers/tty/serial/*, some of the only reacquire the context to reset some hardware registers, since the printing context was lost. In this case, for you, I don't believe that you can't continue trying to send data to other targets, since the original data is gone. In any case, the context reacquire method is nbcon_reacquire_nobuf.