On Mon, Jan 05, 2026 at 05:30:56PM -0800, Jakub Kicinski wrote:

On Fri, 2 Jan 2026 20:57:05 -0800 Dipayaan Roy wrote:

quoted

+		apc = netdev_priv(ndev);
+		disable_work_sync(&apc->queue_reset_work.work);

AI code review points out:

  In mana_remove(), disable_work_sync() is called for each port's
  queue_reset_work. However, when resuming=true, mana_probe() creates a new
  workqueue but does not call mana_probe_port() (which contains INIT_WORK),
  and there is no enable_work() call for queue_reset_work in the resume path.

  The existing link_change_work handles this correctly: it is disabled in
  mana_remove() and re-enabled with enable_work(&ac->link_change_work) in
  mana_probe() when resuming=true.

  Should enable_work(&apc->queue_reset_work.work) be called for each port in
  the resuming path of mana_probe(), similar to how link_change_work is
  handled? Otherwise TX timeout recovery appears to remain disabled after a
  suspend/resume cycle.
-- 
pw-bot: cr

Thanks Jakub for pointing this out. I will send out a new version.

Regards
Dipayaan Roy