Re: [PATCH net-next] net: dlink: count tx_dropped when dropping skb on link down
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-01-06 13:44:56
Also in:
lkml
On Tue, Jan 06, 2026 at 09:23:51PM +0900, Yeounsu Moon wrote:
quoted hunk ↗ jump to hunk
Increment tx_dropped when dropping the skb due to link down. Tested-on: D-Link DGE-550T Rev-A3 Signed-off-by: Yeounsu Moon <redacted> --- drivers/net/ethernet/dlink/dl2k.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/ethernet/dlink/dl2k.c b/drivers/net/ethernet/dlink/dl2k.c index 846d58c769ea..edc6cd64ac56 100644 --- a/drivers/net/ethernet/dlink/dl2k.c +++ b/drivers/net/ethernet/dlink/dl2k.c@@ -733,6 +733,7 @@ start_xmit (struct sk_buff *skb, struct net_device *dev) u64 tfc_vlan_tag = 0; if (np->link_status == 0) { /* Link Down */ + dev->stats.tx_dropped++;
Do you see this being hit very often? It should be that as soon as you know the link is down, you tell the core, and it will stop calling start_xmit. If you see this counter being incremented a lot, it indicates there is a problem somewhere else. You might want to consider converting this driver to phylink. Andrew