-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Friday, January 2, 2026 7:12 PM
To: Haiyang Zhang <redacted>
Cc: linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; KY Srinivasan
[off-list ref]; Haiyang Zhang [off-list ref]; Wei Liu
[off-list ref]; Dexuan Cui [off-list ref]; Andrew Lunn
[off-list ref]; David S. Miller [off-list ref]; Eric
Dumazet [off-list ref]; Paolo Abeni [off-list ref]; Long Li
[off-list ref]; Konstantin Taranov [off-list ref];
Simon Horman [off-list ref]; Erni Sri Satya Vennela
[off-list ref]; Shradha Gupta
[off-list ref]; Saurabh Sengar
[off-list ref]; Aditya Garg
[off-list ref]; Dipayaan Roy
[off-list ref]; Shiraz Saleem
[off-list ref]; linux-kernel@vger.kernel.org; linux-
rdma@vger.kernel.org; Paul Rosswurm [off-list ref]
Subject: [EXTERNAL] Re: [PATCH net-next, 1/2] net: mana: Add support for
coalesced RX packets on CQE

On Fri,  2 Jan 2026 13:35:57 -0800 Haiyang Zhang wrote:

quoted

+		NL_SET_ERR_MSG_FMT(extack, "Set rx-frames to %u failed:%d\n",
+				   ec->rx_max_coalesced_frames, err);

No trailing new line in extack messages, please.
Also please do not duplicate the err value in the message itself,
it's already passed to user space. Well behaved user space will format
this as eg:

  Set rx-frames to 123 failed:-11: Invalid argument

I will update the patch.

Thanks,
- Haiyang