Thread (14 messages) 14 messages, 4 authors, 2026-02-05

Re: [PATCH net 4/4] selftests: drv-net: rss_ctx: test RSS contexts persist after ifdown/up

From: Pavan Chebbi <pavan.chebbi@broadcom.com>
Date: 2026-01-30 03:52:32

Not sure why this is a separate test, TBH. You can remove the test
without the ntuple filters. The two cases I would have expected based
on patches is:

tests1:
 - add a couple of contexts
 - add a n-tuple filter to one of the context
 - ifdown/ifup
 - check contexts and filters are there
 - run some traffic to make sure it flows right

tests2:
 - ifdown
 - add a couple of contexts
 - add a n-tuple filter to one of the context
 - ifup
 - check contexts and filters are there
 - run some traffic to make sure it flows right
Very smart, thanks! When I see such beautiful solutions I curse myself
for not thinking about it in the first place.
You can probably have one shared implementation and pass a param to
it  to tell it whether to "pre-down" the interface.
Yes, Michael also did bring this point up that there is a lot of
shared code between the tests, but I tried to test my luck.
Will be back with a v2. Thanks.
--
pw-bot: cr

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help