Re: [PATCH net-next 3/3] tcp: move tcp_rack_advance() to tcp_input.c
From: Kuniyuki Iwashima <kuniyu@google.com>
Date: 2026-01-27 03:29:18
From: Kuniyuki Iwashima <kuniyu@google.com>
Date: 2026-01-27 03:29:18
On Mon, Jan 26, 2026 at 7:21 PM Eric Dumazet [off-list ref] wrote:
tcp_rack_advance() is called from tcp_ack() and tcp_sacktag_one(). Moving it to tcp_input.c allows the compiler to inline it and save both space and cpu cycles in TCP fast path. $ scripts/bloat-o-meter -t vmlinux.1 vmlinux.2 add/remove: 0/2 grow/shrink: 1/1 up/down: 98/-132 (-34) Function old new delta tcp_ack 5741 5839 +98 tcp_sacktag_one 407 395 -12 __pfx_tcp_rack_advance 16 - -16 tcp_rack_advance 104 - -104 Total: Before=22572680, After=22572646, chg -0.00% Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>