Thread (10 messages) 10 messages, 5 authors, 2026-01-27

Re: [PATCH] team: avoid NETDEV_CHANGEMTU event when unregistering slave

flat view

From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Date: 2026-01-26 11:08:10

On 2026/01/26 11:35, David Ahern wrote:
On 1/25/26 7:35 AM, Tetsuo Handa wrote:
quoted
syzbot is reporting
@@ -1330,7 +1330,13 @@ static int team_port_del(struct team *team, struct net_device *port_dev)
 	__team_port_change_port_removed(port);
 
 	team_port_set_orig_dev_addr(port);
-	dev_set_mtu(port_dev, port->orig.mtu);
+	if (unregister) {
+		netdev_lock_ops(port_dev);
+		__netif_set_mtu(port_dev, port->orig.mtu);
+		netdev_unlock_ops(port_dev);
+	} else {
+		dev_set_mtu(port_dev, port->orig.mtu);
+	}
 	kfree_rcu(port, rcu);
 	netdev_info(dev, "Port device %s removed\n", portname);
 	netdev_compute_master_upper_features(team->dev, true);
same logic as bonding, so a netdev based helper that both drivers can use?
Maybe, but that will be an another patch. No need to combine a local
bugfix patch and a multiple-users cross-modules helper patch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help