Re: [PATCH net-next 6/9] hsr: Implement more robust duplicate discard for HSR
From: kernel test robot <hidden>
Date: 2026-01-21 21:53:19
Also in:
oe-kbuild-all
Hi Felix, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Felix-Maurer/selftests-hsr-Add-ping-test-for-PRP/20260121-221431 base: net-next/main patch link: https://lore.kernel.org/r/a58f3b542fd8564c5d9576a10a9d6c9a7f318931.1769001553.git.fmaurer%40redhat.com patch subject: [PATCH net-next 6/9] hsr: Implement more robust duplicate discard for HSR config: alpha-randconfig-r073-20260122 (https://download.01.org/0day-ci/archive/20260122/202601220557.VfSPsAdo-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 12.5.0 smatch version: v0.5.0-8985-g2614ff1a reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260122/202601220557.VfSPsAdo-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: https://lore.kernel.org/oe-kbuild-all/202601220557.VfSPsAdo-lkp@intel.com/ (local) All warnings (new ones prefixed by >>): net/hsr/hsr_framereg.c: In function 'fill_last_seq_nrs':
quoted
net/hsr/hsr_framereg.c:781:22: warning: variable 'block_off' set but not used [-Wunused-but-set-variable]
781 | unsigned int block_off;
| ^~~~~~~~~
vim +/block_off +781 net/hsr/hsr_framereg.c
773
774 /* Fill the last sequence number that has been received from node on if1 by
775 * finding the last sequence number sent on port B; accordingly get the last
776 * received sequence number for if2 using sent sequence numbers on port A.
777 */
778 static void fill_last_seq_nrs(struct hsr_node *node, u16 *if1_seq, u16 *if2_seq)
779 {
780 struct hsr_seq_block *block;
> 781 unsigned int block_off;
782 size_t block_sz;
783 u16 seq_bit;
784
785 spin_lock_bh(&node->seq_out_lock);
786
787 // Get last inserted block
788 block_off = (node->next_block - 1) & (HSR_MAX_SEQ_BLOCKS - 1);
789 block_sz = hsr_seq_block_size(node);
790 block = node->block_buf + node->next_block * block_sz;
791
792 if (!bitmap_empty(block->seq_nrs[HSR_PT_SLAVE_B - 1],
793 HSR_SEQ_BLOCK_SIZE)) {
794 seq_bit = find_last_bit(block->seq_nrs[HSR_PT_SLAVE_B - 1],
795 HSR_SEQ_BLOCK_SIZE);
796 *if1_seq = (block->block_idx << HSR_SEQ_BLOCK_SHIFT) | seq_bit;
797 }
798 if (!bitmap_empty(block->seq_nrs[HSR_PT_SLAVE_A - 1],
799 HSR_SEQ_BLOCK_SIZE)) {
800 seq_bit = find_last_bit(block->seq_nrs[HSR_PT_SLAVE_A - 1],
801 HSR_SEQ_BLOCK_SIZE);
802 *if2_seq = (block->block_idx << HSR_SEQ_BLOCK_SHIFT) | seq_bit;
803 }
804 spin_unlock_bh(&node->seq_out_lock);
805 }
806
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki