On 1/20/26 9:58 AM, Eric Dumazet wrote:

On Mon, Jan 19, 2026 at 4:10 PM Paolo Abeni [off-list ref] wrote:

quoted

@@ -11385,6 +11385,12 @@ int register_netdevice(struct net_device *dev)
        if (dev->hw_enc_features & NETIF_F_TSO)
                dev->hw_enc_features |= NETIF_F_TSO_MANGLEID;

+       /* Any mangleid feature disables TSO_MANGLEID; including the latter
+        * in mangleid_features allows for better code in the fastpath.
+        */
+       if (dev->mangleid_features)
+               dev->mangleid_features |= NETIF_F_TSO_MANGLEID;
+

It is a bit unclear why you test for anything being set in mangleid_features

I would force here the bit, without any condition ?

      dev->mangleid_features |= NETIF_F_TSO_MANGLEID;

Indeed the check it's not needed. I'll drop it in the next revision, thanks!

Paolo