Re: [PATCH net-next] tcp: move tcp_rate_skb_delivered() to tcp_input.c
From: Neal Cardwell <ncardwell@google.com>
Date: 2026-01-19 16:51:16
From: Neal Cardwell <ncardwell@google.com>
Date: 2026-01-19 16:51:16
On Sun, Jan 18, 2026 at 7:32 AM Eric Dumazet [off-list ref] wrote:
tcp_rate_skb_delivered() is only called from tcp_input.c. Move it there and make it static. Both gcc and clang are (auto)inlining it, TCP performance is increased at a small space cost. $ scripts/bloat-o-meter -t vmlinux.old vmlinux.new add/remove: 0/2 grow/shrink: 3/0 up/down: 509/-187 (322) Function old new delta tcp_sacktag_walk 1682 1867 +185 tcp_ack 5230 5405 +175 tcp_shifted_skb 437 586 +149 __pfx_tcp_rate_skb_delivered 16 - -16 tcp_rate_skb_delivered 171 - -171 Total: Before=22566192, After=22566514, chg +0.00% Signed-off-by: Eric Dumazet <edumazet@google.com> ---
Reviewed-by: Neal Cardwell <ncardwell@google.com> Thanks, Eric! neal