Thread (17 messages) 17 messages, 3 authors, 2026-01-15

Re: [RFC PATCH v5 0/7] net: wwan: add NMEA port type support

From: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Date: 2026-01-14 19:59:25

On 1/14/26 04:42, Slark Xiao wrote:
There is an error based on your RFC changes.
It locates in 7/7 net: wwan: hwsim: support NMEA port emulation.
Error as below:

   CC [M]  drivers/input/gameport/fm801-gp.o
drivers/net/wwan/wwan_hwsim.c: In function ‘wwan_hwsim_nmea_emul_timer’:
drivers/net/wwan/wwan_hwsim.c:239:40: error: implicit declaration of function ‘from_timer’; did you mean ‘mod_timer’? [-Werror=implicit-function-declaration]
   239 |         struct wwan_hwsim_port *port = from_timer(port, t, nmea_emul.timer);
       |                                        ^~~~~~~~~~
       |                                        mod_timer
drivers/net/wwan/wwan_hwsim.c:239:60: error: ‘nmea_emul’ undeclared (first use in this function)
   239 |         struct wwan_hwsim_port *port = from_timer(port, t, nmea_emul.timer);
       |                                                            ^~~~~~~~~
drivers/net/wwan/wwan_hwsim.c:239:60: note: each undeclared identifier is reported only once for each function it appears in
cc1: some warnings being treated as errors
make[5]: *** [scripts/Makefile.build:287: drivers/net/wwan/wwan_hwsim.o] Error 1
make[4]: *** [scripts/Makefile.build:544: drivers/net/wwan] Error 2


This error could be found in netdev-bpf website --Checks --netdev/build_32bit as well.
I just rollback it to previous timer_container_of() function and it builds well.
Ouch. My bad. Thank you, Slark, for noticing and fixing it.

--
Sergey
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help