Re: [PATCH v2 1/5] lsm: Add hook unix_path_connect
From: Paul Moore <paul@paul-moore.com>
Date: 2026-01-13 23:30:49
Also in:
linux-security-module
On Tue, Jan 13, 2026 at 5:51 PM Paul Moore [off-list ref] wrote:
On Sat, Jan 10, 2026 at 11:45 AM Justin Suess [off-list ref] wrote:quoted
On 1/10/26 09:32, Günther Noack wrote:quoted
From: Justin Suess <redacted> Adds an LSM hook unix_path_connect. This hook is called to check the path of a named unix socket before a connection is initiated. Cc: Günther Noack <redacted> Signed-off-by: Justin Suess <redacted> --- include/linux/lsm_hook_defs.h | 4 ++++ include/linux/security.h | 11 +++++++++++ net/unix/af_unix.c | 9 +++++++++ security/security.c | 20 ++++++++++++++++++++ 4 files changed, 44 insertions(+)...quoted
quoted
+#if defined(CONFIG_SECURITY_NETWORK) && defined(CONFIG_SECURITY_PATH) +/* + * security_unix_path_connect() - Check if a named AF_UNIX socket can connect + * @path: path of the socket being connected to + * @type: type of the socket + * @flags: flags associated with the socket + * + * This hook is called to check permissions before connecting to a named + * AF_UNIX socket. + * + * Return: Returns 0 if permission is granted. + */ +int security_unix_path_connect(const struct path *path, int type, int flags) +{ + return call_int_hook(unix_path_connect, path, type, flags); +} +EXPORT_SYMBOL(security_unix_path_connect);...quoted
I'm considering renaming this hook to unix_socket_path_lookup, since as Günther pointed out this hook is not just hit on connect, but also on sendmsg.I'm not bothered too much ...
I forgot to add that I know you're likely going to do another revision to this patchset to rename the hook, but I would suggest waiting until the AppArmor folks have had a chance to look at the hook. I want to make sure the new hook is reasonable and suitably generic for a path-based LSM, and while I suspect it is, having another set of path-based LSM eyes review the hook would be a very good thing. -- paul-moore.com