Re: [net-next,v7,4/6] net/sched: sch_cake: Share config across cake_mq sub-qdiscs
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-01-09 04:12:54
This is an AI-generated review of your patch. For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- net/sched: sch_cake: Share config across cake_mq sub-qdiscs This commit adds support for configuring the cake_mq instance directly, sharing the config across the cake sub-qdiscs.
quoted hunk ↗ jump to hunk
diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c index deb9f411db98..4dbfee3e6207 100644 --- a/net/sched/sch_cake.c +++ b/net/sched/sch_cake.c
[ ... ]
+ if (tb[TCA_CAKE_AUTORATE]) {
+ if (!!nla_get_u32(tb[TCA_CAKE_AUTORATE])) {
+ if (q->is_shared) {
+ NL_SET_ERR_MSG_ATTR(extack, tb[TCA_CAKE_NAT],^^^^^^^^^^^^^^ Should this be tb[TCA_CAKE_AUTORATE] instead of tb[TCA_CAKE_NAT]? The check here is for TCA_CAKE_AUTORATE, but the error message attribute points to TCA_CAKE_NAT. This appears to be a copy-paste from the NAT handling code just above. When a user enables autorate-ingress on cake_mq, the error will reference the wrong netlink attribute.
+ "Can't use autorate-ingress with cake_mq");
+ return -EOPNOTSUPP;
+ }
+ rate_flags |= CAKE_FLAG_AUTORATE_INGRESS;
+ } else {
+ rate_flags &= ~CAKE_FLAG_AUTORATE_INGRESS;
+ }
+ }[ ... ] -- pw-bot: cr