Re: [PATCH RFC net-next v2 8/8] cadence: macb: introduce xmit support
From: Théo Lebrun <theo.lebrun@bootlin.com>
Date: 2026-01-08 15:54:19
On Sun Dec 21, 2025 at 12:51 AM CET, Paolo Valerio wrote:
quoted hunk ↗ jump to hunk
Add XDP_TX verdict support, also introduce ndo_xdp_xmit function for redirection, and update macb_tx_unmap() to handle both skbs and xdp frames advertising NETDEV_XDP_ACT_NDO_XMIT capability and the ability to process XDP_TX verdicts. Signed-off-by: Paolo Valerio <redacted> --- drivers/net/ethernet/cadence/macb_main.c | 166 +++++++++++++++++++++-- 1 file changed, 158 insertions(+), 8 deletions(-)diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index cd29a80d1dbb..d8abfa45e22d 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c +static int +gem_xdp_xmit(struct net_device *dev, int num_frame, + struct xdp_frame **frames, u32 flags) +{
nit: a bit surprised by the first line break in the function header. Especially as it doesn't prevent splitting arguments across two lines. Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com