Thread (3 messages) 3 messages, 3 authors, 2026-01-06

Re: [PATCH net-next] net: marvell: prestera: correct return type of prestera_ldr_wait_buf()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-01-06 00:23:38

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski [off-list ref]:

On Sat,  3 Jan 2026 09:43:10 -0800 you wrote:
prestera_ldr_wait_buf() returns the result of readl_poll_timeout(),
which is 0 on success or -ETIMEDOUT on failure. Its current return
type is u32.

Assigning this u32 value to an int variable works today because the
bit pattern of (u32)-ETIMEDOUT (0xffffff92) is correctly interpreted
as -ETIMEDOUT when stored in an int. However, keeping the function
return type as u32 is misleading and fragile.

[...]
Here is the summary with links:
  - [net-next] net: marvell: prestera: correct return type of prestera_ldr_wait_buf()
    https://git.kernel.org/netdev/net-next/c/32291cb0369a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help