Thread (3 messages) 3 messages, 2 authors, 2025-12-05
STALE177d

[PATCH RFC] powerpc: switch two fixed phy links to full duplex

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: 2025-12-05 17:21:54
Also in: linux-devicetree, linuxppc-dev
Subsystem: linux for powerpc (32-bit and 64-bit), the rest · Maintainers: Madhavan Srinivasan, Michael Ellerman, Linus Torvalds

These two fixed links are the only ones in-kernel specifying half duplex.
If these could be switched to full duplex, then half duplex handling
could be removed from phylib fixed phy, phylink, swphy.

The SoC MAC's are capable of full duplex, fs_enet MAC driver is as well.
Anything that would keep us from switching to full duplex?

Whilst at it, replace the deprecated old fixed-link binding.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 arch/powerpc/boot/dts/mgcoge.dts | 6 +++++-
 arch/powerpc/boot/dts/tqm8xx.dts | 6 +++++-
 2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/boot/dts/mgcoge.dts b/arch/powerpc/boot/dts/mgcoge.dts
index 9cefed20723..cea9bdc65dc 100644
--- a/arch/powerpc/boot/dts/mgcoge.dts
+++ b/arch/powerpc/boot/dts/mgcoge.dts
@@ -153,7 +153,11 @@ eth0: ethernet@11a60 {
 				interrupt-parent = <&PIC>;
 				linux,network-index = <0>;
 				fsl,cpm-command = <0xce00000>;
-				fixed-link = <0 0 10 0 0>;
+
+				fixed-link {
+					speed = <10>;
+					full-duplex;
+				};
 			};
 
 			i2c@11860 {
diff --git a/arch/powerpc/boot/dts/tqm8xx.dts b/arch/powerpc/boot/dts/tqm8xx.dts
index d16cdfd8120..e582487d5a3 100644
--- a/arch/powerpc/boot/dts/tqm8xx.dts
+++ b/arch/powerpc/boot/dts/tqm8xx.dts
@@ -185,7 +185,11 @@ eth0: ethernet@a00 {
 				interrupt-parent = <&CPM_PIC>;
 				fsl,cpm-command = <0000>;
 				linux,network-index = <0>;
-				fixed-link = <0 0 10 0 0>;
+
+				fixed-link {
+					speed = <10>;
+					full-duplex;
+				};
 			};
 		};
 	};
-- 
2.52.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help