On 12/29/25 2:47 AM, Illusion Wang wrote:

发件人：Paolo Abeni [off-list ref]
发送时间：2025年12月23日(周二) 15:08
收件人：Illusion Wang[off-list ref]; Dimon[off-list ref]; Alvin[off-list ref]; Sam[off-list ref]; netdev[off-list ref]
抄　送：open list[off-list ref]
主　题：Re: [PATCH v1 net-next 00/15] nbl driver for Nebulamatrix NICs


On 12/23/25 4:50 AM, illusion.wang wrote:

quoted

The patch series add the nbl driver, which will support the nebula-matrix 18100 and 18110 series 
of network cards.
This submission is the first phase. which includes the PF-based and VF-based Ethernet transmit 
and receive functionality. Once this is merged. will submit addition patches to implement support
for other features. such as ethtool support, debugfs support and etc.
Our Driver architecture  supports Kernel Mode and Coexistence Mode(kernel and dpdk)

Not a real review, but this series has several basic issues:

- each patch should compile and build without warnings on all arches
- don't use inline in c code
- avoid using 'module_params'
- the preferred line width is still 80 chars

quoted

quoted

quoted

quoted

quoted

Thanks for your quick reply!
However, I noticed that at
https://github.com/torvalds/linux/commit/bdc48fa11e46f867ea4d75fa59ee87a7f48be144,
And the checkpatch tool checks for a line width of 100 columns. If we make the change to 80 characters, it might reduce readability.
Could our driver set the limit to 100 columns instead?

Please use consistent top quoting in your next replies. This one is
quite unreadable.

Networking still uses 80 column boundaries: please adapt your code
accordingly.

Thanks,

Paolo