Thread (4 messages) 4 messages, 3 authors, 2026-01-08

Re: [PATCH net-next] vsock/test: add a final full barrier after run all tests

From: Luigi Leonardi <hidden>
Date: 2025-12-24 13:20:02
Also in: lkml, virtualization

On Tue, Dec 23, 2025 at 05:22:10PM +0100, Stefano Garzarella wrote:
quoted hunk ↗ jump to hunk
From: Stefano Garzarella <sgarzare@redhat.com>

If the last test fails, the other side still completes correctly,
which could lead to false positives.

Let's add a final barrier that ensures that the last test has finished
correctly on both sides, but also that the two sides agree on the
number of tests to be performed.

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
tools/testing/vsock/util.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
index d843643ced6b..9430ef5b8bc3 100644
--- a/tools/testing/vsock/util.c
+++ b/tools/testing/vsock/util.c
@@ -511,6 +511,18 @@ void run_tests(const struct test_case *test_cases,
		printf("ok\n");
	}
+
+	printf("All tests have been executed. Waiting other peer...");
+	fflush(stdout);
+
+	/*
+	 * Final full barrier, to ensure that all tests have been run and
+	 * that even the last one has been successful on both sides.
+	 */
+	control_writeln("COMPLETED");
+	control_expectln("COMPLETED");
+
+	printf("ok\n");
}

void list_tests(const struct test_case *test_cases)
-- 
2.52.0
LGTM!

Reviewed-by: Luigi Leonardi <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help