Thread (27 messages) 27 messages, 4 authors, 2025-12-31

Re: [PATCH net 1/3] virtio-net: make refill work a per receive queue work

From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Date: 2025-12-24 01:39:50
Also in: bpf, lkml, virtualization

Hi Jason,

I'm wondering why we even need this refill work. Why not simply let NAPI retry
the refill on its next run if the refill fails? That would seem much simpler.
This refill work complicates maintenance and often introduces a lot of
concurrency issues and races.

Thanks.

On Wed, 24 Dec 2025 08:52:36 +0800, Jason Wang [off-list ref] wrote:
On Tue, Dec 23, 2025 at 11:27 PM Bui Quang Minh
[off-list ref] wrote:
quoted
Currently, the refill work is a global delayed work for all the receive
queues. This commit makes the refill work a per receive queue so that we
can manage them separately and avoid further mistakes. It also helps the
successfully refilled queue avoid the napi_disable in the global delayed
refill work like before.

Signed-off-by: Bui Quang Minh <redacted>
---
I may miss something but I think this patch is sufficient to fix the problem?

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help