Re: [PATCH net-next v7 4/9] net: let pp memory provider to specify rx buf len

From
Pavel Begunkov <asml.silence@gmail.com>
Date
2025-12-11 01:31:13
Also in
bpf, io-uring, linux-doc, linux-kselftest, lkml
Reply to
Jakub Kicinski, 2025-12-02
On 12/2/25 19:04, Jakub Kicinski wrote:
On Sun, 30 Nov 2025 23:35:19 +0000 Pavel Begunkov wrote:
quoted
+enum {
+	/* queue restart support custom rx buffer sizes */
+	NDO_QUEUE_RX_BUF_SIZE		= 0x1,
If you have to respin -- let's drop the NDO from this define.
To suggest something specific - QCFG_ is a better prefix?
IDK why we ended up with ndo_ prefix on the queue ops..
QCFG_ sounds better indeed
Also RX_PAGE_SIZE is a better name for the fields? RX_BUF_SIZE
is easy to confuse with RX_BUF_LEN which we are no longer trying
to modify.
It's not "page" because there are no struct page's, and those are
just buffers. Maybe it's also some net/driver specific term?
I don't get the difference here b/w "size" and "len" either, but
in any case I don't really have any real opinion about the name,
and it can always be changed later.

-- 
Pavel Begunkov
Thread (20 messages) 20 messages, 4 authors, last reply 2025-12-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help