Re: [PATCH net 3/3] net: hns3: add VLAN id validation before using
From: Simon Horman <horms@kernel.org>
Date: 2025-12-09 16:50:18
Also in:
lkml
From: Simon Horman <horms@kernel.org>
Date: 2025-12-09 16:50:18
Also in:
lkml
On Tue, Dec 09, 2025 at 09:38:25PM +0800, Jijie Shao wrote:
From: Jian Shen <shenjian15@huawei.com>
Currently, the VLAN id may be used without validation when
receive a VLAN configuration mailbox from VF. It may cause
out-of-bounds memory access once the VLAN id is bigger than
4095.
Fixes: fe4144d47eef ("net: hns3: sync VLAN filter entries when kill VLAN ID failed")
Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Jijie Shao <shaojijie@huawei.com>Hi Jijie, Can you clarify that the (only) oob access is to vlan_del_fail_bmap? If so, I agree with this change and that the problem was introduced in the cited commit. But I think it would be worth mentioning vlan_del_fail_bmap in the commit message. ...