On Thu, Dec 04, 2025 at 12:03:29PM -0800, Kees Cook wrote:

On Thu, Dec 04, 2025 at 09:16:16AM -0800, Guenter Roeck wrote:

quoted

On Thu, Dec 04, 2025 at 08:27:54AM -0800, Jakub Kicinski wrote:

quoted

On Thu,  4 Dec 2025 08:17:14 -0800 Guenter Roeck wrote:

quoted

This series fixes build errors observed when trying to build selftests
with -Werror.

If your intention is to make -Werror the default please stop.
Defaulting WERROR to enabled is one of the silliest things we have done
in recent past.

No, that is not the idea, and not the intention.

The Google infrastructure builds the kernel, including selftests, with
-Werror enabled. This triggers a number of build errors when trying to
build selftests with the 6.18 kernel. That means I have three options:
1) Disable -Werror in selftest builds and accept that some real problems
   will slip through. Not really a good option, and not acceptable.
2) Fix the problems in the upstream kernel and backport.

The series fixes build warnings that appear regardless of -Werror,
yes? That on its face is an improvement, so maybe just adjust the
Subject/changelogs?

Yes, I'll do that.

Thanks,
Guenter