Thread (9 messages) 9 messages, 5 authors, 2025-12-05

Re: [PATCH net] net/mlx5: Fix double unregister of HCA_PORTS component

From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-12-04 14:33:07
Also in: linux-pci, linux-rdma, linux-s390, lkml

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni [off-list ref]:

On Tue, 02 Dec 2025 12:12:57 +0100 you wrote:
Clear hca_devcom_comp in device's private data after unregistering it in
LAG teardown. Otherwise a slightly lagging second pass through
mlx5_unload_one() might try to unregister it again and trip over
use-after-free.

On s390 almost all PCI level recovery events trigger two passes through
mxl5_unload_one() - one through the poll_health() method and one through
mlx5_pci_err_detected() as callback from generic PCI error recovery.
While testing PCI error recovery paths with more kernel debug features
enabled, this issue reproducibly led to kernel panics with the following
call chain:

[...]
Here is the summary with links:
  - [net] net/mlx5: Fix double unregister of HCA_PORTS component
    https://git.kernel.org/netdev/net/c/6a107cfe9c99

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help