Hi Simon,

On 02/12/25 9:51 pm, Simon Horman wrote:

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On Mon, Dec 01, 2025 at 08:53:45AM +0530, Parthiban Veerasooran wrote:

...

quoted

+int genphy_c45_oatc14_get_sqi_max(struct phy_device *phydev)
+{
+     int ret;
+
+     if (!phydev->oatc14_sqi_capability.updated) {
+             ret = oatc14_update_sqi_capability(phydev);
+             if (ret)
+                     return ret;
+     }

Hi Parthiban,

I think the check for phydev->oatc14_sqi_capability.updated can be folded
into oatc14_update_sqi_capability(), avoiding duplicating it here and in
genphy_c45_oatc14_get_sqi().

If you agree, could you consider posting a follow-up once net-next has
re-opened?

Yes, I agree with you. Thanks for pointing it out. I will send a 
separate patch for doing this once the net-next is reopened again.

Best regards,
Parthiban V

quoted

+
+     return phydev->oatc14_sqi_capability.sqi_max;
+}
+EXPORT_SYMBOL(genphy_c45_oatc14_get_sqi_max);
+
+/**
+ * genphy_c45_oatc14_get_sqi - Get Signal Quality Indicator (SQI) from an OATC14
+ *                          10Base-T1S PHY
+ * @phydev: pointer to the PHY device structure
+ *
+ * This function reads the SQI+ or SQI value from an OATC14-compatible
+ * 10Base-T1S PHY. If SQI+ capability is supported, the function returns the
+ * extended SQI+ value; otherwise, it returns the basic SQI value. The SQI
+ * capability is updated on first invocation if it has not already been updated.
+ *
+ * Return:
+ * * SQI/SQI+ value on success
+ * * Negative errno on read failure
+ */
+int genphy_c45_oatc14_get_sqi(struct phy_device *phydev)
+{
+     u8 shift;
+     int ret;
+
+     if (!phydev->oatc14_sqi_capability.updated) {
+             ret = oatc14_update_sqi_capability(phydev);
+             if (ret)
+                     return ret;
+     }