Thread (10 messages) 10 messages, 4 authors, 2025-12-28

Re: [PATCH v2] af_unix: don't post cmsg for SO_INQ unless explicitly asked for

From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-12-28 15:35:21
Also in: io-uring

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni [off-list ref]:

On Thu, 18 Dec 2025 15:21:28 -0700 you wrote:
A previous commit added SO_INQ support for AF_UNIX (SOCK_STREAM), but it
posts a SCM_INQ cmsg even if just msg->msg_get_inq is set. This is
incorrect, as ->msg_get_inq is just the caller asking for the remainder
to be passed back in msg->msg_inq, it has nothing to do with cmsg. The
original commit states that this is done to make sockets
io_uring-friendly", but it's actually incorrect as io_uring doesn't use
cmsg headers internally at all, and it's actively wrong as this means
that cmsg's are always posted if someone does recvmsg via io_uring.

[...]
Here is the summary with links:
  - [v2] af_unix: don't post cmsg for SO_INQ unless explicitly asked for
    https://git.kernel.org/netdev/net/c/4d1442979e4a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help