Re: [PATCH net-next v2 7/7] qede: convert to use ndo_hwtstamp callbacks
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Date: 2025-11-05 13:36:56
Also in:
linux-arm-kernel
On 05/11/2025 01:43, Jakub Kicinski wrote:
On Mon, 3 Nov 2025 15:09:52 +0000 Vadim Fedorenko wrote:quoted
ptp->hw_ts_ioctl_called = 1; - ptp->tx_type = config.tx_type; - ptp->rx_filter = config.rx_filter; + ptp->tx_type = config->tx_type; + ptp->rx_filter = config->rx_filter; rc = qede_ptp_cfg_filters(edev); - if (rc) + if (rc) { + NL_SET_ERR_MSG_MOD(extack, + "One-step timestamping is not supported"); return rc; + } + + config->rx_filter = ptp->rx_filter;Same story as the first patch. I suppose these drives may predate the advanced tx config options. Simple fix would be to move the tx_filter validation here instead. I'll apply 2-6.
Got it. I'll send fixed versions of patch 1 and patch 7, thanks!