On Mon, 10 Nov 2025 19:34:40 -0800 Saeed Mahameed wrote:

On 10 Nov 15:01, Jakub Kicinski wrote:

quoted

On Fri, 7 Nov 2025 22:14:45 -0800 Saeed Mahameed wrote:  

quoted

Plug in the err, NL_SET_ERR_MSG_FMT_MOD(.., .., err);
other locations as well.  

Incorrect. extack should basically be passed to perror()
IOW user space will add strerror(errno) after, anyway.
Adding the errno inside the string is pointless and ugly.  

ernno set by stack. err set by driver. we can't assume err will propagate
to errno, this is up to the stack.

And not at all ugly, very useful debug hint to the user, unless you
guarantee err == errno.

Not propagating errno should be fixed, if that happens.
We need clear expectations to avoid the messages being all over 
the place. Historically we haven't included err because formatting
was not an option. So I think we should continue this way.