Thread (13 messages) 13 messages, 5 authors, 2025-11-09

Re: [PATCH net-next v2 2/2] net/mlx5: implement swp_l4_csum_mode via devlink params

From: Daniel Zahka <daniel.zahka@gmail.com>
Date: 2025-11-04 14:48:24
Also in: intel-wired-lan, linux-doc, linux-omap, linux-rdma


On 11/4/25 9:39 AM, Jiri Pirko wrote:
Tue, Nov 04, 2025 at 01:51:16PM +0100, daniel.zahka@gmail.com wrote:
quoted
On 11/4/25 6:38 AM, Daniel Zahka wrote:
quoted
On 11/4/25 5:14 AM, Jiri Pirko wrote:
quoted
I did some research. 0/DEVICE_DEFAULT should not be ever reported back
from FW. It's purpose is for user to reset to default FW configuration.
What's the usecase for that? I think you could just avoid
0/DEVICE_DEFAULT entirely, for both get and set.
I find that 0/DEVICE_DEFAULT is reported back on my device. I have
observed this same behavior when using the mstconfig tool for setting the
parameter too.
e.g.
$ dmesg | grep -i mlx | grep -i firmware
[   10.165767] mlx5_core 0000:01:00.0: firmware version: 28.46.1006

$ ./mstconfig -d 01:00.0 -b ./mlxconfig_host.db query SWP_L4_CHECKSUM_MODE

Device #1:
----------

Device type:        ConnectX7
Name:               CX71143DMC-CDAE_FB_Ax
Description:        ConnectX-7 Ethernet adapter card; 100 GbE OCP3.0;
Single-port QSFP; Multi Host; 2 Host; PCIe 4.0 x16; Crypto and Secure Boot
Device:             01:00.0

Configurations:                                          Next Boot
         SWP_L4_CHECKSUM_MODE DEVICE_DEFAULT(0)
This is next-boot value. You should query current (--enable_verbosity)
to show in param get.
I am still seeing that DEVICE_DEFAULT(0) is read back:

$ ./mstconfig --enable_verbosity -d 01:00.0 -b ./mlxconfig_host.db query 
SWP_L4_CHECKSUM_MODE

Device #1:
----------

Device type:        ConnectX7
Name:               CX71143DMC-CDAE_FB_Ax
Description:        ConnectX-7 Ethernet adapter card; 100 GbE OCP3.0; 
Single-port QSFP; Multi Host; 2 Host; PCIe 4.0 x16; Crypto and Secure Boot
Device:             01:00.0

Configurations:                  Default             Current       Next Boot
         SWP_L4_CHECKSUM_MODE DEVICE_DEFAULT(0) DEVICE_DEFAULT(0)    
DEVICE_DEFAULT(0)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help