Thread (29 messages) 29 messages, 5 authors, 2025-11-20

Re: [PATCH net-next v4 11/14] netkit: Implement rtnl_link_ops->alloc and ndo_queue_create

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2025-11-07 15:02:19
Also in: bpf

On 11/7/25 1:41 AM, Jakub Kicinski wrote:
On Fri, 31 Oct 2025 22:21:00 +0100 Daniel Borkmann wrote:
quoted
+static void netkit_get_channels(struct net_device *dev,
+				struct ethtool_channels *channels)
+{
+	channels->max_rx = dev->num_rx_queues;
+	channels->max_tx = dev->num_tx_queues;
+	channels->max_other = 0;
+	channels->max_combined = 1;
+	channels->rx_count = dev->real_num_rx_queues;
+	channels->tx_count = dev->real_num_tx_queues;
+	channels->other_count = 0;
+	channels->combined_count = 0;
  }
Why do we need to implement get_channels?
Thanks for the feedback. I think this one was useful imho since it allowed
for introspection via ethtool on netkit side e.g. the max_rx vs rx_count.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help