On 11/25/25 4:51 PM, hch@lst.de wrote:

On Tue, Nov 25, 2025 at 04:43:25PM +0530, Nilay Shroff wrote:

quoted

The memalloc_noreclaim_save() above shall already prevent filesystem
reclaim,

memalloc_noreclaim_save is oddly misnamed, as it sets the
PF_MEMALLOC, which does not cause any gfp_t flag adjustments, but
instead avoid direct reclaim.  Thinking of it I have no idea why
it is even used here.

From git history, I see that was added to avoid memory reclaim  to avoid
possible circular locking dependency. This commit 83e1226b0ee2 ("nvme-tcp:
fix possible circular locking when deleting a controller under memory
pressure") adds it.

Thanks,
--Nilay