Thread (2 messages) 2 messages, 2 authors, 2025-11-29

Re: [PATCH net] net: netpoll: initialize work queue before error checks

From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-11-29 04:33:17
Also in: lkml

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski [off-list ref]:

On Thu, 27 Nov 2025 07:30:15 -0800 you wrote:
Prevent a kernel warning when netconsole setup fails on devices with
IFF_DISABLE_NETPOLL flag. The warning (at kernel/workqueue.c:4242 in
__flush_work) occurs because the cleanup path tries to cancel an
uninitialized work queue.

When __netpoll_setup() encounters a device with IFF_DISABLE_NETPOLL,
it fails early and calls skb_pool_flush() for cleanup. This function
calls cancel_work_sync(&np->refill_wq), but refill_wq hasn't been
initialized yet, triggering the warning.

[...]
Here is the summary with links:
  - [net] net: netpoll: initialize work queue before error checks
    https://git.kernel.org/netdev/net/c/e5235eb6cfe0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help