Re: [PATCH net-next v8 1/1] Documentation: net: add flow control guide and document ethtool API
From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-11-28 18:33:02
Also in:
lkml
From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-11-28 18:33:02
Also in:
lkml
On Fri, 28 Nov 2025 09:55:22 +0100 Oleksij Rempel wrote:
* **Constraint Checking:**
* Drivers MUST accept a setting of @autoneg (true) even if generic
* link autonegotiation ('ethtool -s / --change') is currently disabled.
* This allows the user to pre-configure the desired policy for future
* link modes.!? I pointed out so many times that this contradicts the long standing recommendation. Can you please tell me what is preventing us from deprecating pauseparam API *for autoneg* and using linkmodes which are completely unambiguous. And allows the user to "pre configure" the advertisement. The pause set API should remain primarily for forced mode configuration. Perhaps the move is to make it read only for new drivers when aneg is turned on?