On Thu, 2025-11-27 at 15:28 +0000, Simon Horman wrote:

On Tue, Nov 25, 2025 at 10:06:05PM +0200, Tariq Toukan wrote:

quoted

 net/devlink/netlink_gen.c                |  5 ++
 net/devlink/netlink_gen.h                |  8 +++

Hi,

I think that the updates to netlink_gen.[ch] belong in
the following patch rather than this one.

You can observe this using

tools/net/ynl/ynl-regen.sh -f && git diff

Hi,

You are right, some of these changes belong to the next patch. We will
fix in the next submission.
But running ynl-regen.sh results in unbuildable code, due to missing
devlink_dl_parent_dev_nl_policy. It seems it is not added unless the
attribute is referenced in at least one attribute set.
Additionally, the devlink_nl_pre_doit_parent_dev_optional needs to be
manually added to netlink-gen.{h,c}, as it is not automatically
generated.

Cosmin.