[v3, net-next 11/12] bng_en: Create per-PF workqueue and timer for asynchronous events
From: Bhargava Marreddy <hidden>
Date: 2025-11-26 19:50:54
Also in:
lkml
Subsystem:
broadcom bng_en 800 gigabit ethernet driver, networking drivers, the rest · Maintainers:
Vikas Gupta, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Use a dedicated workqueue and timer for each PF to handle events. This sets up the infrastructure for the next patch, which will implement the event handling logic. Signed-off-by: Bhargava Marreddy <redacted> Reviewed-by: Vikas Gupta <vikas.gupta@broadcom.com> Reviewed-by: Rajashekar Hudumula <redacted> --- drivers/net/ethernet/broadcom/bnge/bnge.h | 10 ++++++ .../net/ethernet/broadcom/bnge/bnge_core.c | 35 ++++++++++++++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 31 ++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 3 ++ 4 files changed, 78 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge.h b/drivers/net/ethernet/broadcom/bnge/bnge.h
index 72d9865ba7b..0b75d6139b1 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge.h
+++ b/drivers/net/ethernet/broadcom/bnge/bnge.h@@ -136,6 +136,7 @@ struct bnge_dev { unsigned long state; #define BNGE_STATE_DRV_REGISTERED 0 #define BNGE_STATE_OPEN 1 +#define BNGE_STATE_IN_SP_TASK 2 u64 fw_cap;
@@ -208,9 +209,18 @@ struct bnge_dev { u8 max_q; u8 port_count; + unsigned int current_interval; +#define BNGE_TIMER_INTERVAL HZ + + struct timer_list timer; struct bnge_irq *irq_tbl; u16 irqs_acquired; + struct workqueue_struct *bnge_pf_wq; + struct work_struct sp_task; + unsigned long sp_event; +#define BNGE_PERIODIC_STATS_SP_EVENT 0 + /* To protect link related settings during link changes and * ethtool settings changes. */
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_core.c b/drivers/net/ethernet/broadcom/bnge/bnge_core.c
index 2c72dd34d50..dfa501f912a 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_core.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_core.c@@ -238,6 +238,23 @@ static int bnge_map_db_bar(struct bnge_dev *bd) return 0; } +static struct workqueue_struct * +bnge_create_workqueue_thread(struct bnge_dev *bd, char thread_name[]) +{ + struct workqueue_struct *wq; + char *wq_name; + + wq_name = kasprintf(GFP_KERNEL, "%s-%s", thread_name, + dev_name(bd->dev)); + if (!wq_name) + return NULL; + + wq = create_singlethread_workqueue(wq_name); + + kfree(wq_name); + return wq; +} + static int bnge_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent) { unsigned int max_irqs;
@@ -277,6 +294,10 @@ static int bnge_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent) goto err_devl_free; } + INIT_WORK(&bd->sp_task, bnge_sp_task); + timer_setup(&bd->timer, bnge_timer, 0); + bd->current_interval = BNGE_TIMER_INTERVAL; + rc = bnge_init_hwrm_resources(bd); if (rc) goto err_bar_unmap;
@@ -318,14 +339,24 @@ static int bnge_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent) goto err_config_uninit; } + bd->bnge_pf_wq = bnge_create_workqueue_thread(bd, "bnge_pf_wq"); + if (!bd->bnge_pf_wq) { + dev_err(&pdev->dev, "Unable to create workqueue.\n"); + rc = -ENOMEM; + goto err_free_irq; + } + rc = bnge_netdev_alloc(bd, max_irqs); if (rc) - goto err_free_irq; + goto err_free_workq; pci_save_state(pdev); return 0; +err_free_workq: + destroy_workqueue(bd->bnge_pf_wq); + err_free_irq: bnge_free_irqs(bd);
@@ -356,6 +387,8 @@ static void bnge_remove_one(struct pci_dev *pdev) bnge_netdev_free(bd); + destroy_workqueue(bd->bnge_pf_wq); + bnge_free_irqs(bd); bnge_net_uninit_dflt_config(bd);
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
index f9d7f90a825..824374c1d9c 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c@@ -253,6 +253,33 @@ static int bnge_alloc_ring_stats(struct bnge_net *bn) return rc; } +void bnge_timer(struct timer_list *t) +{ + struct bnge_dev *bd = timer_container_of(bd, t, timer); + struct bnge_net *bn = netdev_priv(bd->netdev); + struct net_device *dev = bd->netdev; + + if (!netif_running(dev) || !test_bit(BNGE_STATE_OPEN, &bd->state)) + return; + + if (atomic_read(&bn->intr_sem) != 0) + goto bnge_restart_timer; + +bnge_restart_timer: + mod_timer(&bd->timer, jiffies + bd->current_interval); +} + +void bnge_sp_task(struct work_struct *work) +{ + struct bnge_dev *bd = container_of(work, struct bnge_dev, sp_task); + + set_bit(BNGE_STATE_IN_SP_TASK, &bd->state); + smp_mb__after_atomic(); + + smp_mb__before_atomic(); + clear_bit(BNGE_STATE_IN_SP_TASK, &bd->state); +} + static void bnge_free_nq_desc_arr(struct bnge_nq_ring_info *nqr) { struct bnge_ring_struct *ring = &nqr->ring_struct;
@@ -2111,6 +2138,7 @@ static void bnge_disable_int_sync(struct bnge_net *bn) struct bnge_dev *bd = bn->bd; int i; + atomic_inc(&bn->intr_sem); bnge_disable_int(bn); for (i = 0; i < bd->nq_nr_rings; i++) { int map_idx = bnge_cp_num_to_irq_num(bn, i);
@@ -2124,6 +2152,7 @@ static void bnge_enable_int(struct bnge_net *bn) struct bnge_dev *bd = bn->bd; int i; + atomic_set(&bn->intr_sem, 0); for (i = 0; i < bd->nq_nr_rings; i++) { struct bnge_napi *bnapi = bn->bnapi[i]; struct bnge_nq_ring_info *nqr = &bnapi->nq_ring;
@@ -2677,6 +2706,7 @@ static int bnge_open_core(struct bnge_net *bn) bnge_enable_int(bn); bnge_tx_enable(bn); + mod_timer(&bd->timer, jiffies + bd->current_interval); /* Poll link status and check for SFP+ module status */ mutex_lock(&bd->link_lock); bnge_get_port_module_status(bn);
@@ -2718,6 +2748,7 @@ static void bnge_close_core(struct bnge_net *bn) clear_bit(BNGE_STATE_OPEN, &bd->state); bnge_shutdown_nic(bn); bnge_disable_napi(bn); + timer_delete_sync(&bd->timer); bnge_free_all_rings_bufs(bn); bnge_free_irq(bn); bnge_del_napi(bn);
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h
index d7713bd57c6..9f5430d4180 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h@@ -352,6 +352,7 @@ struct bnge_net { unsigned long state; #define BNGE_STATE_NAPI_DISABLED 0 + atomic_t intr_sem; u32 msg_enable; u16 max_tpa;
@@ -646,4 +647,6 @@ int bnge_alloc_rx_netmem(struct bnge_net *bn, struct bnge_rx_ring_info *rxr, void bnge_get_ring_err_stats(struct bnge_net *bn, struct bnge_total_ring_err_stats *stats); void bnge_copy_hw_masks(u64 *mask_arr, __le64 *hw_mask_arr, int count); +void bnge_timer(struct timer_list *t); +void bnge_sp_task(struct work_struct *work); #endif /* _BNGE_NETDEV_H_ */
--
2.47.3