Re: [PATCH net-next 5/9] phy: add phy_get_rx_polarity() and phy_get_tx_polarity()
From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-11-25 04:01:23
Also in:
linux-arm-kernel, linux-devicetree, linux-mediatek, linux-phy, lkml
On Sat, 22 Nov 2025 21:33:37 +0200 Vladimir Oltean wrote:
Add helpers in the generic PHY folder which can be used using 'select GENERIC_PHY_COMMON_PROPS' from Kconfig, without otherwise needing to enable GENERIC_PHY. These helpers need to deal with the slight messiness of the fact that the polarity properties are arrays per protocol, and with the fact that there is no default value mandated by the standard properties, all default values depend on driver and protocol (PHY_POL_NORMAL may be a good default for SGMII, whereas PHY_POL_AUTO may be a good default for PCIe). Push the supported mask of polarities to these helpers, to simplify drivers such that they don't need to validate what's in the device tree (or other firmware description). The proposed maintainership model is joint custody between netdev and linux-phy, because of the fact that these properties can be applied to Ethernet PCS blocks just as well as Generic PHY devices. I've added as maintainers those from "ETHERNET PHY LIBRARY", "NETWORKING DRIVERS" and "GENERIC PHY FRAMEWORK".
I dunno.. ain't no such thing as "joint custody" maintainership. We have to pick one tree. Given the set of Ms here, I suspect the best course of action may be to bubble this up to its own tree. Ask Konstantin for a tree in k.org, then you can "co-post" the patches for review + PR link in the cover letter (e.g. how Tony from Intel submits their patches). This way not networking and PHY can pull the shared changes with stable commit IDs. We can do out-of-sequence netdev call tomorrow if folks want to talk this thru (8:30am Pacific)
+GENERIC PHY COMMON PROPERTIES +M: Andrew Lunn [off-list ref] +M: "David S. Miller" [off-list ref] +M: Eric Dumazet [off-list ref] +M: Heiner Kallweit [off-list ref] +M: Jakub Kicinski [off-list ref] +M: Kishon Vijay Abraham I [off-list ref] +M: Paolo Abeni [off-list ref] +R: Russell King [off-list ref] +M: Vinod Koul [off-list ref]
checkpatch nit: apparently it wants all Ms first, then all Rs.
+L: linux-phy@lists.infradead.org +L: netdev@vger.kernel.org +S: Maintained +Q: https://patchwork.kernel.org/project/linux-phy/list/ +Q: https://patchwork.kernel.org/project/netdevbpf/list/ +T: git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git +T: git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git +T: git git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git +F: Documentation/devicetree/bindings/phy/phy-common-props.yaml +F: drivers/phy/phy-common-props.c
-- pw-bot: cr