On Thu, 2025-11-06 at 08:27 +1100, NeilBrown wrote:

On Thu, 06 Nov 2025, Jeff Layton wrote:

quoted

As Neil points out:

"I would be in favour of dropping the "dir" arg because it is always
d_inode(dentry->d_parent) which is stable."

...and...

"Also *every* caller of vfs_create() passes ".excl = true".  So maybe we
don't need that arg at all."

Drop both arguments from vfs_create() and fix up the callers.

Suggested-by: NeilBrown <redacted>
Signed-off-by: Jeff Layton <jlayton@kernel.org>

This I like.

Reviewed-by: NeilBrown <neil@brown.name>

It would be consistent to also remove the 'dir' arg from vfs_mkdir(),
vfs_mknod(), etc.  I wouldn't do that until we find out what other
people think of the change.

I was thinking that too. I can roll patches to do those as well, but at
this point I think I'd rather do that on top of this series rather than
in the context of it.
-- 
Jeff Layton [off-list ref]