[PATCH 07/16] backing-file: use credential guards for mmap
From: Christian Brauner <brauner@kernel.org>
Date: 2025-11-03 11:27:27
Also in:
cgroups, linux-cifs, linux-fsdevel, linux-nfs, linux-unionfs, lkml
Subsystem:
filesystems (vfs and infrastructure), filesystems [stackable], the rest · Maintainers:
Alexander Viro, Christian Brauner, Miklos Szeredi, Amir Goldstein, Linus Torvalds
Use credential guards for scoped credential override with automatic restoration on scope exit. Signed-off-by: Christian Brauner <brauner@kernel.org> --- fs/backing-file.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/backing-file.c b/fs/backing-file.c
index 9c63a3368b66..5cc4b59aa460 100644
--- a/fs/backing-file.c
+++ b/fs/backing-file.c@@ -331,7 +331,6 @@ EXPORT_SYMBOL_GPL(backing_file_splice_write); int backing_file_mmap(struct file *file, struct vm_area_struct *vma, struct backing_file_ctx *ctx) { - const struct cred *old_cred; struct file *user_file = vma->vm_file; int ret;
@@ -343,9 +342,8 @@ int backing_file_mmap(struct file *file, struct vm_area_struct *vma, vma_set_file(vma, file); - old_cred = override_creds(ctx->cred); - ret = vfs_mmap(vma->vm_file, vma); - revert_creds(old_cred); + scoped_with_creds(ctx->cred) + ret = vfs_mmap(vma->vm_file, vma); if (ctx->accessed) ctx->accessed(user_file);
--
2.47.3