Re: [PATCH v6 3/4] crypto: ti - Add support for AES-GCM in DTHEv2 driver

Hi Pratham,

kernel test robot noticed the following build warnings:

[auto build test WARNING on herbert-crypto-2.6/master]
[also build test WARNING on linus/master v6.18-rc5]
[cannot apply to herbert-cryptodev-2.6/master next-20251113]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/T-Pratham/crypto-ti-Add-support-for-AES-XTS-in-DTHEv2-driver/20251111-192827
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git master
patch link:    https://lore.kernel.org/r/20251111112137.976121-4-t-pratham%40ti.com
patch subject: [PATCH v6 3/4] crypto: ti - Add support for AES-GCM in DTHEv2 driver
config: s390-randconfig-002-20251114 (https://download.01.org/0day-ci/archive/20251114/202511141528.zox1IMuF-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251114/202511141528.zox1IMuF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot [off-list ref]
| Closes: https://lore.kernel.org/oe-kbuild-all/202511141528.zox1IMuF-lkp@intel.com/ (local)

All warnings (new ones prefixed by >>):

   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_init_tfm':
   drivers/crypto/ti/dthev2-aes.c:573:24: error: implicit declaration of function 'crypto_alloc_sync_aead'; did you mean 'crypto_alloc_aead'? [-Werror=implicit-function-declaration]
     573 |         ctx->aead_fb = crypto_alloc_sync_aead(alg_name, 0,
         |                        ^~~~~~~~~~~~~~~~~~~~~~
         |                        crypto_alloc_aead

quoted

drivers/crypto/ti/dthev2-aes.c:573:22: warning: assignment to 'struct crypto_sync_aead *' from 'int' makes pointer from integer without a cast [-Wint-conversion]

     573 |         ctx->aead_fb = crypto_alloc_sync_aead(alg_name, 0,
         |                      ^
   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_exit_tfm':
   drivers/crypto/ti/dthev2-aes.c:588:9: error: implicit declaration of function 'crypto_free_sync_aead'; did you mean 'crypto_free_aead'? [-Werror=implicit-function-declaration]
     588 |         crypto_free_sync_aead(ctx->aead_fb);
         |         ^~~~~~~~~~~~~~~~~~~~~
         |         crypto_free_aead
   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_setkey':
   drivers/crypto/ti/dthev2-aes.c:831:9: error: implicit declaration of function 'crypto_sync_aead_clear_flags'; did you mean 'crypto_aead_clear_flags'? [-Werror=implicit-function-declaration]
     831 |         crypto_sync_aead_clear_flags(ctx->aead_fb, CRYPTO_TFM_REQ_MASK);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |         crypto_aead_clear_flags
   drivers/crypto/ti/dthev2-aes.c:832:9: error: implicit declaration of function 'crypto_sync_aead_set_flags'; did you mean 'crypto_aead_set_flags'? [-Werror=implicit-function-declaration]
     832 |         crypto_sync_aead_set_flags(ctx->aead_fb,
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
         |         crypto_aead_set_flags
   drivers/crypto/ti/dthev2-aes.c:836:16: error: implicit declaration of function 'crypto_sync_aead_setkey'; did you mean 'crypto_aead_setkey'? [-Werror=implicit-function-declaration]
     836 |         return crypto_sync_aead_setkey(ctx->aead_fb, key, keylen);
         |                ^~~~~~~~~~~~~~~~~~~~~~~
         |                crypto_aead_setkey
   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_setauthsize':
   drivers/crypto/ti/dthev2-aes.c:846:16: error: implicit declaration of function 'crypto_sync_aead_setauthsize'; did you mean 'crypto_aead_setauthsize'? [-Werror=implicit-function-declaration]
     846 |         return crypto_sync_aead_setauthsize(ctx->aead_fb, authsize);
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                crypto_aead_setauthsize
   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_do_fallback':
   drivers/crypto/ti/dthev2-aes.c:854:9: error: implicit declaration of function 'SYNC_AEAD_REQUEST_ON_STACK'; did you mean 'SYNC_SKCIPHER_REQUEST_ON_STACK'? [-Werror=implicit-function-declaration]
     854 |         SYNC_AEAD_REQUEST_ON_STACK(subreq, ctx->aead_fb);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
         |         SYNC_SKCIPHER_REQUEST_ON_STACK
   drivers/crypto/ti/dthev2-aes.c:854:36: error: 'subreq' undeclared (first use in this function)
     854 |         SYNC_AEAD_REQUEST_ON_STACK(subreq, ctx->aead_fb);
         |                                    ^~~~~~
   drivers/crypto/ti/dthev2-aes.c:854:36: note: each undeclared identifier is reported only once for each function it appears in

quoted

drivers/crypto/ti/dthev2-aes.c:863:1: warning: control reaches end of non-void function [-Wreturn-type]

     863 | }
         | ^
   cc1: some warnings being treated as errors


vim +573 drivers/crypto/ti/dthev2-aes.c

   563	
   564	static int dthe_aead_init_tfm(struct crypto_aead *tfm)
   565	{
   566		struct dthe_tfm_ctx *ctx = crypto_aead_ctx(tfm);
   567		struct dthe_data *dev_data = dthe_get_dev(ctx);
   568	
   569		ctx->dev_data = dev_data;
   570	
   571		const char *alg_name = crypto_tfm_alg_name(crypto_aead_tfm(tfm));
   572	
 > 573		ctx->aead_fb = crypto_alloc_sync_aead(alg_name, 0,
   574						      CRYPTO_ALG_NEED_FALLBACK);
   575		if (IS_ERR(ctx->aead_fb)) {
   576			dev_err(dev_data->dev, "fallback driver %s couldn't be loaded\n",
   577				alg_name);
   578			return PTR_ERR(ctx->aead_fb);
   579		}
   580	
   581		return 0;
   582	}
   583	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki